search

saltstack-formulas / mysql-formula

Install the MySQL client and/or server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
85 stars 367 forks source link

feat(yamllint): include for this repo and apply rules throughout #225

Closed myii closed 5 years ago

myii commented 5 years ago 
mysql-formula$ $(grep "\- yamllint" .travis.yml | sed -e "s:^\s\+-\s\(.*\):\1:")
./mysql/osfamilymap.yaml
  4:1       warning  missing document start "---"  (document-start)
  5:6       error    syntax error: found character '%' that cannot start any token
  94:17     error    trailing spaces  (trailing-spaces)
  191:89    error    line too long (90 > 88 characters)  (line-length)

./mysql/defaults.yaml
  3:1       warning  missing document start "---"  (document-start)
  7:4       error    syntax error: found character '%' that cannot start any token
  44:89     error    line too long (93 > 88 characters)  (line-length)
  51:89     error    line too long (111 > 88 characters)  (line-length)
  58:89     error    line too long (104 > 88 characters)  (line-length)
  65:89     error    line too long (103 > 88 characters)  (line-length)
  71:89     error    line too long (95 > 88 characters)  (line-length)
  77:89     error    line too long (102 > 88 characters)  (line-length)
  83:89     error    line too long (101 > 88 characters)  (line-length)
  86:89     error    line too long (95 > 88 characters)  (line-length)
  90:89     error    line too long (95 > 88 characters)  (line-length)

./mysql/supported_sections.yaml
  2:2       error    syntax error: found character '%' that cannot start any token

./mysql/osmap.yaml
  4:4       error    syntax error: found character '%' that cannot start any token
  7:89      error    line too long (96 > 88 characters)  (line-length)
  8:89      error    line too long (97 > 88 characters)  (line-length)

pillar.example
  1:1       warning  missing document start "---"  (document-start)
  36:8      error    wrong indentation: expected 8 but found 7  (indentation)
  77:16     warning  truthy value should be one of [false, true]  (truthy)
  80:13     warning  truthy value should be one of [false, true]  (truthy)
  83:13     warning  truthy value should be one of [false, true]  (truthy)
  85:13     warning  truthy value should be one of [false, true]  (truthy)
  89:13     warning  truthy value should be one of [false, true]  (truthy)
  96:13     warning  truthy value should be one of [false, true]  (truthy)
  112:19    warning  truthy value should be one of [false, true]  (truthy)
  117:17    warning  too few spaces before comment  (comments)
  118:12    warning  truthy value should be one of [false, true]  (truthy)
  119:17    warning  truthy value should be one of [false, true]  (truthy)
  130:25    warning  truthy value should be one of [false, true]  (truthy)
  131:19    warning  truthy value should be one of [false, true]  (truthy)
  153:16    warning  truthy value should be one of [false, true]  (truthy)
  166:14    warning  truthy value should be one of [false, true]  (truthy)
  171:18    warning  truthy value should be one of [false, true]  (truthy)
  172:89    error    line too long (93 > 88 characters)  (line-length)
  175:18    warning  truthy value should be one of [false, true]  (truthy)
  176:89    error    line too long (111 > 88 characters)  (line-length)
  179:18    warning  truthy value should be one of [false, true]  (truthy)
  179:26    warning  missing starting space in comment  (comments)
  180:89    error    line too long (104 > 88 characters)  (line-length)
  183:18    warning  truthy value should be one of [false, true]  (truthy)
  183:26    warning  missing starting space in comment  (comments)
  184:89    error    line too long (103 > 88 characters)  (line-length)
  187:18    warning  truthy value should be one of [false, true]  (truthy)
  187:26    warning  missing starting space in comment  (comments)
  188:89    error    line too long (95 > 88 characters)  (line-length)
  191:18    warning  truthy value should be one of [false, true]  (truthy)
  191:26    warning  missing starting space in comment  (comments)
  192:89    error    line too long (102 > 88 characters)  (line-length)
  195:18    warning  truthy value should be one of [false, true]  (truthy)
  195:26    warning  missing starting space in comment  (comments)
  196:89    error    line too long (101 > 88 characters)  (line-length)
  199:18    warning  truthy value should be one of [false, true]  (truthy)
  199:26    warning  missing starting space in comment  (comments)
  200:89    error    line too long (95 > 88 characters)  (line-length)
  203:18    warning  truthy value should be one of [false, true]  (truthy)
  203:26    warning  missing starting space in comment  (comments)
  204:89    error    line too long (95 > 88 characters)  (line-length)
  207:18    warning  truthy value should be one of [false, true]  (truthy)
  207:26    warning  missing starting space in comment  (comments)
  211:18    warning  truthy value should be one of [false, true]  (truthy)
  211:26    warning  missing starting space in comment  (comments)
  214:1     error    too many blank lines (1 > 0)  (empty-lines)

test/salt/pillar/mysql.sls
  1:1       warning  missing document start "---"  (document-start)
  36:8      error    wrong indentation: expected 8 but found 7  (indentation)
  77:16     warning  truthy value should be one of [false, true]  (truthy)
  80:13     warning  truthy value should be one of [false, true]  (truthy)
  82:13     warning  truthy value should be one of [false, true]  (truthy)
  84:13     warning  truthy value should be one of [false, true]  (truthy)
  88:13     warning  truthy value should be one of [false, true]  (truthy)
  95:13     warning  truthy value should be one of [false, true]  (truthy)
  111:19    warning  truthy value should be one of [false, true]  (truthy)
  152:16    warning  truthy value should be one of [false, true]  (truthy)
  165:14    warning  truthy value should be one of [false, true]  (truthy)
  170:18    warning  truthy value should be one of [false, true]  (truthy)
  171:89    error    line too long (93 > 88 characters)  (line-length)
  174:18    warning  truthy value should be one of [false, true]  (truthy)
  175:89    error    line too long (111 > 88 characters)  (line-length)
  178:18    warning  truthy value should be one of [false, true]  (truthy)
  178:26    warning  missing starting space in comment  (comments)
  179:89    error    line too long (104 > 88 characters)  (line-length)
  182:18    warning  truthy value should be one of [false, true]  (truthy)
  182:26    warning  missing starting space in comment  (comments)
  183:89    error    line too long (103 > 88 characters)  (line-length)
  186:18    warning  truthy value should be one of [false, true]  (truthy)
  186:26    warning  missing starting space in comment  (comments)
  187:89    error    line too long (95 > 88 characters)  (line-length)
  190:18    warning  truthy value should be one of [false, true]  (truthy)
  190:26    warning  missing starting space in comment  (comments)
  191:89    error    line too long (102 > 88 characters)  (line-length)
  194:18    warning  truthy value should be one of [false, true]  (truthy)
  194:26    warning  missing starting space in comment  (comments)
  195:89    error    line too long (101 > 88 characters)  (line-length)
  198:18    warning  truthy value should be one of [false, true]  (truthy)
  198:26    warning  missing starting space in comment  (comments)
  199:89    error    line too long (95 > 88 characters)  (line-length)
  202:18    warning  truthy value should be one of [false, true]  (truthy)
  202:26    warning  missing starting space in comment  (comments)
  203:89    error    line too long (95 > 88 characters)  (line-length)
  206:18    warning  truthy value should be one of [false, true]  (truthy)
  206:26    warning  missing starting space in comment  (comments)
  210:18    warning  truthy value should be one of [false, true]  (truthy)
  210:26    warning  missing starting space in comment  (comments)
  213:1     error    too many blank lines (1 > 0)  (empty-lines)

Refer back to: https://github.com/saltstack-formulas/template-formula/pull/159#issue-305203039.

This PR has taken quite some time because some parts of this formula are poorly structured. During this refactor, I haven't addressed those issues just yet but I've introduced an improved structure to base those fixes from. I've run extensive tests on each of the available platforms, to ensure that the same map is being produced before and after this PR, including the erroneous parts. I will discuss those issues in subsequent edits and/or comments.

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.52.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: