search

saltstack-formulas / mysql-formula

Install the MySQL client and/or server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
85 stars 367 forks source link

ci(yamllint): add rule `empty-values` & use new `yaml-files` setting #228

Closed myii closed 5 years ago

myii commented 5 years ago 
mysql-formula$ yamllint -s .
./mysql/osfamilymap.yaml
  46:14     error    empty value in block mapping  (empty-values)
  66:14     error    empty value in block mapping  (empty-values)
  67:14     error    empty value in block mapping  (empty-values)
  68:16     error    empty value in block mapping  (empty-values)
  69:17     error    empty value in block mapping  (empty-values)
  70:16     error    empty value in block mapping  (empty-values)
  87:7      error    empty value in block mapping  (empty-values)
  216:14    error    empty value in block mapping  (empty-values)
  217:17    error    empty value in block mapping  (empty-values)

./mysql/defaults.yaml
  29:10     error    empty value in block mapping  (empty-values)
  30:11     error    empty value in block mapping  (empty-values)
myii commented 5 years ago

Need to fix before merging:

        yamllint:
          rules:
            empty-values:
              ignore:
                - mysql/defaults.yaml
                - mysql/osfamilymap.yaml
myii commented 5 years ago

@noelmcloughlin Initial cross-reference: https://github.com/saltstack-formulas/template-formula/issues/164.

I'm requesting your review here because I'm not happy with the fixes being applied. The empty values that are currently there translate to null, which I've explicitly set using ~. That doesn't seem right in the context, though. What are these values supposed to be? Or should those entries be commented out?

The defaults.yaml fixes are fine, it's the osfamilymap.yaml values that I'm asking about.

myii commented 5 years ago

Used inline yamllint ignores to get around this issue in the meantime. Transferred this to issue #229. Self-merging alongside all of the other formulas that have already incorporated this.

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.52.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: