saltstack-formulas / mysql-formula

Install the MySQL client and/or server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
85 stars 366 forks source link

fix(mac_shortcut.sh): fix `shellcheck` errors #233

Closed myii closed 4 years ago

myii commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Needs to be merged ASAP, so that the builds no longer fail, e.g. #232.

Describe the changes you're proposing

Fix these errors:

In mysql/files/mac_shortcut.sh line 5:
if [[ -e "{{ home }}/{{ user }}/Desktop/{{ app }}" ]] && [[ "${1}" -eq "remove" ]]
                                                                       ^------^ SC2154: remove is referenced but not assigned.
In mysql/files/mac_shortcut.sh line 8:
elif [[ -e "{{ dir }}/{{ app ~ '.app' if suffix else app }}" ]] && [[ "${1}" -eq "add" ]]
                                                                                 ^---^ SC2154: add is referenced but not assigned.

CC: @noelmcloughlin.

Pillar / config required to test the proposed changes

N/A.

Debug log showing how the proposed changes work

Travis lint job passes.

Documentation checklist

Testing checklist

Additional context

myii commented 4 years ago

Thanks for the review, @aboe76. Merging quickly because builds are failing, needed before merging #232, for example.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.52.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: