Closed miska closed 4 years ago
Best reviewed: commit by commit
Powered by Pull Assistant. Last update 8ee79a7 ... 8ee79a7. Read the comment docs.
@miska Thanks for this PR. It's always helpful to provide upstream references if possible. I've linked the package below:
Do you mind giving a reference for the socket?
Otherwise, this looks good and thanks for fixing the commit message!
@miska Note, it's always advantageous to use a separate branch (other than master
, i.e. a feature branch) for submitting PRs. Otherwise, it can block the use of the master
branch in your own fork, since whatever you do there will update this PR here (usually not desirable). Especially for PRs that take some time to get reviewed and merged.
@miska Merged, thanks for clarifying things.
:tada: This PR is included in version 0.52.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Updated requirements and configuration for SUSE
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context