saltstack-formulas / mysql-formula

Install the MySQL client and/or server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
85 stars 369 forks source link

fix(osfamilymap.yaml): Update SUSE defaults #240

Closed miska closed 4 years ago

miska commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Updated requirements and configuration for SUSE

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix(osfamilymap.yaml): update SUSE defaults

Powered by Pull Assistant. Last update 8ee79a7 ... 8ee79a7. Read the comment docs.

myii commented 4 years ago

@miska Thanks for this PR. It's always helpful to provide upstream references if possible. I've linked the package below:

Do you mind giving a reference for the socket?

Otherwise, this looks good and thanks for fixing the commit message!

myii commented 4 years ago

@miska Note, it's always advantageous to use a separate branch (other than master, i.e. a feature branch) for submitting PRs. Otherwise, it can block the use of the master branch in your own fork, since whatever you do there will update this PR here (usually not desirable). Especially for PRs that take some time to get reviewed and merged.

miska commented 4 years ago

Socket comes from line 384 in https://build.opensuse.org/package/view_file/openSUSE:Leap:15.1:Update/mariadb/mariadb.spec?expand=1 and https://en.opensuse.org/openSUSE:Packaging_Conventions_RPM_Macros#.25_rundir

myii commented 4 years ago

@miska Merged, thanks for clarifying things.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.52.7 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: