Closed Yoda-BZH closed 4 years ago
Best reviewed: commit by commit
Powered by Pull Assistant. Last update d8de27d ... d8de27d. Read the comment docs.
any update?
or do I need to do something on my end ?
Thank you !
Hi, @Yoda-BZH . The changes LGTM, but commitlint
is complaining in some of your commits messages missing the required headers for semantic versioning.
Mind you amend those messages (or squash your commits) and force-push, so we can merge them? Thanks!
I think I fixed the commit message, but I broke the bot :s
Hah! It's complaining on message length.
feat(socket_authentication): allow unix_socket authentication
will do OK
There you go, used @javierbertoli's suggestion to get this merged without troubling @Yoda-BZH any further! Thanks for the contribution, that's been merged.
:tada: This PR is included in version 0.54.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
thank you !
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
None
Describe the changes you're proposing
Allow the creation of user with the
unix_socket
plugin.Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context