saltstack-formulas / mysql-formula

Install the MySQL client and/or server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
85 stars 369 forks source link

feat(socket_authentication) Allow user to authenticate with unix_socket plugin #246

Closed Yoda-BZH closed 4 years ago

Yoda-BZH commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

None

Describe the changes you're proposing

Allow the creation of user with the unix_socket plugin.

Pillar / config required to test the proposed changes

mysql:
  user:
    myuser:
      host: localhost
      unix_socket: true

Debug log showing how the proposed changes work

mysql_user_myuser_localhost:
    mysql_user.present:
      - name: myuser
      - host: 'localhost'
      - allow_passwordless: True
      - unix_socket: True
      - connection_host: 'localhost'
      - connection_user: 'root'
      - connection_pass: 'admin'
      - connection_charset: utf8

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     feat(socket_authentication): Allow creation of users with unix_socket ...

Powered by Pull Assistant. Last update d8de27d ... d8de27d. Read the comment docs.

Yoda-BZH commented 4 years ago

any update?

or do I need to do something on my end ?

Thank you !

javierbertoli commented 4 years ago

Hi, @Yoda-BZH . The changes LGTM, but commitlint is complaining in some of your commits messages missing the required headers for semantic versioning.

Mind you amend those messages (or squash your commits) and force-push, so we can merge them? Thanks!

Yoda-BZH commented 4 years ago

I think I fixed the commit message, but I broke the bot :s

javierbertoli commented 4 years ago

Hah! It's complaining on message length.

feat(socket_authentication): allow unix_socket authentication

will do OK

myii commented 4 years ago

There you go, used @javierbertoli's suggestion to get this merged without troubling @Yoda-BZH any further! Thanks for the contribution, that's been merged.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.54.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Yoda-BZH commented 4 years ago

thank you !