fix(FreeBSD): upgrade to mysql57-server

GeJ commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[x] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Current default version for FreeBSD is MySQL 5.7, also python 2.x is deprecated and should be removed any time soon.

FreeBSD uses the mysql_install_db which generates a temporary root password upon the first start. To the best of my understanding I haven't seen any code in the formula that handles this method. So I added a FreeBSD-scpecific block for initialization. While here, create /var/log/mysql without which the server won't start if it doesn't exist.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan

Update FreeBSD to mysql57-server

Powered by Pull Assistant. Last update 845af54 ... 845af54. Read the comment docs.

GeJ commented 4 years ago

It's almost 1AM, and I just realized I botched it. I'm closing it for now and will update with a new version tomorrow morning. Sorry for the noise.

GeJ commented 4 years ago

I'm reopening the PR. Sorry, I thought I had seen a mistake on my end, but after a few more tests locally, the only mistake was trying to review my code at 1 AM.

Again, really sorry for the going back and forth on this one. I'll try to be more careful next time.

myii commented 4 years ago

Merged, thanks @GeJ. I adjusted the commit message so that semantic-release works properly.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.54.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / mysql-formula