saltstack-formulas / mysql-formula

Install the MySQL client and/or server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
85 stars 369 forks source link

fix(salt-user): redirect error output from user access checks #260

Closed pprkut closed 3 years ago

pprkut commented 3 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

May fix #230

Describe the changes you're proposing

When commands used in the onlyif condition had output on STDERR, the condition wouldn't evaluate correctly. A redirect of STDERR to STDOUT fixed the conditions for me and now the states work again as intended.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

myii commented 3 years ago

Thanks for the fix, @pprkut -- merged.

Appreciate the review, @javierbertoli.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 0.55.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: