Closed ixs closed 3 years ago
@ixs Could you fix the commit message to comply with conventional commit: https://www.conventionalcommits.org/en/v1.0.0/#summary git commit --amend
, etc. thanks
Hi @ixs Can you do git commit --amend
and change to "refactor(jinja): improve indentation" and I'll merge. thanks
@noelmcloughlin done. Thanks for following up here.
LGTM, thanks @ixs
:tada: This PR is included in version 0.56.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
The indentation in servers.sls was unclear and made following the control flow much harder.
Fix that by correctly indenting.
Drive-By: Change {% to {%- no-line-break opening tags for variable logic
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context