saltstack-formulas / mysql-formula

Install the MySQL client and/or server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
85 stars 366 forks source link

refactor(jinja): improve indentation #263

Closed ixs closed 3 years ago

ixs commented 3 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

The indentation in servers.sls was unclear and made following the control flow much harder.

Fix that by correctly indenting.

Drive-By: Change {% to {%- no-line-break opening tags for variable logic

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

noelmcloughlin commented 3 years ago

@ixs Could you fix the commit message to comply with conventional commit: https://www.conventionalcommits.org/en/v1.0.0/#summary git commit --amend , etc. thanks

noelmcloughlin commented 3 years ago

Hi @ixs Can you do git commit --amend and change to "refactor(jinja): improve indentation" and I'll merge. thanks

ixs commented 3 years ago

@noelmcloughlin done. Thanks for following up here.

noelmcloughlin commented 3 years ago

LGTM, thanks @ixs

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 0.56.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: