Open andrii-suse opened 1 year ago
I think that instead of using a lib as a shebang, you should source the file.
~The advantage of shebang is that the .sh file can be sourced in some scenarios. E.g. if I have custom way to set up test container and still run 10-password.sh in it (just as bash script, not as executable). Then all initialization is skipped and test scenario is still useful.~
Edit: Ah I don't need to execute those commands that are in the .sh files. I need to setup test environment and pass those commands into that environment. So source
will not work.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
267
Describe the changes you're proposing
Currently CI uses kitchen in gitlab runners, which is good, but heavy solution with complex dependencies and non-trivial setup. It is closer to system level testing. This PR proposes CI on unit-test level, with is convenient way to quickly verify correctness of formula changes or reproduce bugs, etc. Additional features:
Pillar / config required to test the proposed changes
-
Debug log showing how the proposed changes work
Linked github workflow should have the logs.
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context