fix(bug): config arrays as multiple lines

waynegemmell commented 1 year ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[x] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

https://github.com/saltstack-formulas/mysql-formula/issues/275

Describe the changes you're proposing

Details are in the issue attached but my change iterates through an array of parameters and writes the parameters on indivitual lines rather than dumping an array into the configuration file. The array dump is not parsable by mysql and it causes issues.

Pillar / config required to test the proposed changes

Example

mysql:
  server_config:
    file: 50-server.cnf
    # my.cnf sections changes
    sections:
      mysqld:
        replicate-ignore-table:
          - core.table1
          - core.table2                 
          - core.table3

currently gets interpreted as

replicate-ignore-table = ['core.table1', 'core.table2', 'core.table3'] rather than the correct

replicate-ignore-table                  = 'core.table1'
replicate-ignore-table                  = 'core.table2'
replicate-ignore-table                  = 'core.table3'

This works on any array config value.

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

jeff350 commented 11 months ago

@waynegemmell I just got the CI fixed for this formula, could you please rebase off of master for the CI tests to run.

saltstack-formulas-github commented 9 months ago

:tada: This PR is included in version 0.56.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / mysql-formula