feat: update python packages for onedir - Githubissues

saltstack-formulas / mysql-formula

Install the MySQL client and/or server

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

85 stars 367 forks source link

feat: update python packages for onedir #278

Open didiermfb opened 11 months ago

didiermfb commented 11 months ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Make the formula compatible with onedir

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[x] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Add packages and python module to make the formula compatible with onedir

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

sylvainfaivre commented 11 months ago

Yesterday in the formulas working group meeting, he had a chat about formulas compatibility with onedir packaging, and the shared opinion was that formulas should be updated to support onedir. Legacy release support may be dropped (this will then be a BREAKING CHANGE), as people willing to use legacy releases can point to older formulas releases.

Regarding the packages to install, I think your code is only compatible with Debian-based distributions. You should use map.jinja and related yaml files to install the required packages according to the OS.