search

saltstack-formulas / nagios-formula

nagios-formula
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
21 stars 73 forks source link

nrpe_commands as dict and list #27

Closed patrickkirsch closed 8 years ago

patrickkirsch commented 8 years ago

In the case of hierarchical design it is desirable to have overriding behaviour.

Signed-off-by: patrick.kirsch@olanis.de patrick.kirsch@olanis.de

gravyboat commented 8 years ago

Hmm, does anyone remember if the mapping value is going to cause issues with older releases of Jinja? I feel like we've run into this before...

puneetk commented 8 years ago

Its an issue in jinja < 2.6, but that's been out for a while.

gravyboat commented 8 years ago

waits with baited breath for an issue 20 minutes from now.

puneetk commented 8 years ago

oh boy

wwentland commented 8 years ago

This breaks if nrpe_commands isn't defined:

----------
          ID: /etc/nagios/nrpe.cfg
    Function: file.managed
      Result: False
     Comment: Unable to manage file: Jinja variable 'dict object' has no attribute 'nrpe_commands'
     Started: 13:53:47.626577
    Duration: 22.57 ms
     Changes:   
----------
          ID: nrpe-server-service
    Function: service.running
        Name: nagios-nrpe-server
      Result: False
     Comment: One or more requisite failed: nagios.nrpe.server./etc/nagios/nrpe.cfg
     Started: 
    Duration: 
     Changes: