search

saltstack-formulas / nagios-formula

nagios-formula
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
21 stars 73 forks source link

Split file.recurse of plugins from nrpe.plugin #50

Open dafyddj opened 7 years ago

dafyddj commented 7 years ago

https://github.com/saltstack-formulas/nagios-formula/blob/14737d35e57fb02aa6efb300a019307d89df10b4/nagios/nrpe/plugin.sls#L3-L13

These two states do not belong together. The NRPE plugin goes on the Nagios server, and the additional plugins belong on the monitored hosts.

I propose moving lines 7-13 to nagios.plugins, although that would obviously require a change for anyone depending on the current behaviour.

aboe76 commented 6 years ago

@dafyddj please create a PR for this, so it can be reviewed