search

saltstack-formulas / nfs-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Apache License 2.0
18 stars 83 forks source link

Semantic release #33

Closed daks closed 4 years ago

daks commented 4 years ago

PR progress checklist (to be filled in by reviewers)

What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Implement semantic-release on nfs-formula with kitchen and travis-ci. No inspec tests are written yet, but there are already problems running this formula on Centos/Fedora.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

Two things remain:

daks commented 4 years ago

@myii thanks for the review. I updated my code. Feel free to had commits to it to fix remaining bugs.

myii commented 4 years ago

@daks I'll add the commits shortly, just running the final tests:

Just going to collect some of the research here in the meantime.

Fedora

CentOS

All working except for CentOS-6. Can only get up to Service nfs has been enabled, and is dead.

Inside the container, get the following:

[kitchen@localhost ~]$ sudo service nfs start
FATAL: Could not load /lib/modules/3.13.0-66-generic/modules.dep: No such file or directory
Starting NFS services:                                     [  OK  ]
Starting NFS mountd:                                       [FAILED]
Starting NFS daemon:                                       [  OK  ]
Starting RPC idmapd:                                       [  OK  ]
[kitchen@localhost ~]$ service nfs status
rpc.svcgssd is stopped
rpc.mountd dead but subsys locked
nfsd dead but subsys locked
[kitchen@localhost ~]$ sudo service nfs stop
Shutting down NFS daemon:                                  [FAILED]
Shutting down NFS mountd:                                  [FAILED]
Shutting down RPC idmapd:                                  [  OK  ]
myii commented 4 years ago

So all but centos-6 working:

I'll add the commits now, @daks.

myii commented 4 years ago

@daks I've just added the commits. A quick explanation of each:

fix(osmap): update service_name for current versions of Fedora

fix(osfingermap): update service_name for CentOS-6

fix(map.jinja): add missing reference to osfinger grain

ci(travis): finalise enabled instances

myii commented 4 years ago

@daks Do you want to add the InSpec tests to this first before merging?

daks commented 4 years ago

Good job @myii :) I think PR can be merged now, and tests be added later.

Do we squash commits before merging or not?

myii commented 4 years ago

You're welcome, @daks. Do the commits need to be squashed? Pretty much all of them represent separate issues or bugs that have been fixed. Better for the changelog as well. If you're OK with that, we can go ahead with the merge.

myii commented 4 years ago

docs/README.md can be removed, right?

myii commented 4 years ago

And another tiny change here:

template should be changed accordingly. We really need to make that update you suggested a few months back about the "main state(s)"...

myii commented 4 years ago

OK, since these were all trivial changes, I've just added them and force pushed. Once the tests pass, I'll merge this.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.11.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

daks commented 4 years ago

nice, thanks