Closed daks closed 4 years ago
@myii thanks for the review. I updated my code. Feel free to had commits to it to fix remaining bugs.
@daks I'll add the commits shortly, just running the final tests:
Just going to collect some of the research here in the meantime.
All working except for CentOS-6
. Can only get up to Service nfs has been enabled, and is dead
.
Inside the container, get the following:
[kitchen@localhost ~]$ sudo service nfs start
FATAL: Could not load /lib/modules/3.13.0-66-generic/modules.dep: No such file or directory
Starting NFS services: [ OK ]
Starting NFS mountd: [FAILED]
Starting NFS daemon: [ OK ]
Starting RPC idmapd: [ OK ]
[kitchen@localhost ~]$ service nfs status
rpc.svcgssd is stopped
rpc.mountd dead but subsys locked
nfsd dead but subsys locked
[kitchen@localhost ~]$ sudo service nfs stop
Shutting down NFS daemon: [FAILED]
Shutting down NFS mountd: [FAILED]
Shutting down RPC idmapd: [ OK ]
So all but centos-6
working:
I'll add the commits now, @daks.
@daks I've just added the commits. A quick explanation of each:
service_name
for current versions of Fedoraservice_name
for CentOS-6
nfs-server
beforehandosfinger
grainmap.jinja
centos-6
isn't working@daks Do you want to add the InSpec tests to this first before merging?
Good job @myii :) I think PR can be merged now, and tests be added later.
Do we squash commits before merging or not?
You're welcome, @daks. Do the commits need to be squashed? Pretty much all of them represent separate issues or bugs that have been fixed. Better for the changelog as well. If you're OK with that, we can go ahead with the merge.
docs/README.md
can be removed, right?
And another tiny change here:
template
should be changed accordingly. We really need to make that update you suggested a few months back about the "main state(s)"...
OK, since these were all trivial changes, I've just added them and force pushed. Once the tests pass, I'll merge this.
:tada: This PR is included in version 0.11.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
nice, thanks
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Implement semantic-release on nfs-formula with kitchen and travis-ci. No inspec tests are written yet, but there are already problems running this formula on Centos/Fedora.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context
Two things remain:
pillar.example