search

saltstack-formulas / nginx-formula

Nginx Salt Formula
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
163 stars 421 forks source link

Updating log_format in pillar.example #219

Closed garrettw closed 5 years ago

garrettw commented 5 years ago

Continuing changes discussed in #217.

The main issue that needs discussing/testing is whether the access_log line (141 after this first commit) still needs to be part of log_format as a workaround (see #122) rather than just using the following line to specify it in YAML format.

myii commented 5 years ago

This new format works well in 2019.2. Need to ensure this works for 2017.7 and 2018.3 as well.

myii commented 5 years ago

@daks If you do get around to changing the tests to inspec, could you include this change somehow? The current pillar should end up with a strange result, in any case.

myii commented 5 years ago

@garrettw Thanks for this. After #229 updated the test matrix, I was able to add another test to confirm this is working for all minions (in #231). Test results here: https://travis-ci.org/myii/nginx-formula/builds/524996941.

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.56.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: