search

saltstack-formulas / nginx-formula

Nginx Salt Formula
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
163 stars 419 forks source link

test(inspec): more tests on nginx config #222

Closed daks closed 5 years ago

daks commented 5 years ago

Some more tests on config files generated: snippets and sites

myii commented 5 years ago

@daks The new testing matrix is doing it's job! So the tests are passing for Debian and Ubuntu but not the other platforms.

daks commented 5 years ago

Yes, I wrote those naively, based on Debian knowledge. I now need to adapt them to other platforms, looking at the code.

daks commented 5 years ago

After disabling OpenSuse42 tests, all pass.

myii commented 5 years ago

@daks Fantastic work. If opensuse can't be fixed, this is ready to be merged, right? In the meantime, @aboe76 do you have any suggestions about how we can get it working? The last failing log is here. Linked issue: #224.

daks commented 5 years ago

@myii for me, it's ok to merge without opensuse

daks commented 5 years ago

@myii can you refresh my memory about this PR and what is still missing?

myii commented 5 years ago

@daks Just need to append this commit: https://github.com/myii/nginx-formula/commit/3fa262bdb90f27bff197bf2c53438ddf5c38420b.

myii commented 5 years ago

Brilliant @daks, thanks for this beneficial PR! Merged.

daks commented 5 years ago

Thanks for merging and for solving opensuse :)