search

saltstack-formulas / nginx-formula

Nginx Salt Formula
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
163 stars 421 forks source link

[BUG] events / worker_connections set to 768 in default configuration #261

Closed arthurzenika closed 4 years ago

arthurzenika commented 4 years ago

Bug details

Describe the bug

After upgrading to a new formula 

                  +events {
                  +    worker_connections 768;
                  +}

https://nginx.org/en/docs/ngx_core_module.html#worker_connections seems to indicate a default of 512, what is the rational for this different default here ?

myii commented 4 years ago

Looking through the history, that was introduced by @daks in 0fc5070 (#232); perhaps he has more information about it. Also relevant to this discussion:

daks commented 4 years ago

Not sure why I added this setting, maybe just because tests didn't pass without it. May be worth to try without.

myii commented 4 years ago

@daks Thanks, we'll modify the default to be 512, then.

myii commented 4 years ago

@arthurlogilab @daks I've prepared #262 to deal with this.

saltstack-formulas-travis commented 4 years ago

:tada: This issue has been resolved in version 2.3.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: