saltstack-formulas / nginx-formula

Nginx Salt Formula
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
163 stars 421 forks source link

[BUG] handle of stub_status #281

Open sposs opened 3 years ago

sposs commented 3 years ago

Your setup

Formula commit hash / release tag

Latest git as of today.

Versions reports (master & minion)

Salt Version: Salt: 3003

Dependency Versions: cffi: Not Installed cherrypy: Not Installed dateutil: 2.7.3 docker-py: Not Installed gitdb: 2.0.5 gitpython: 2.1.11 Jinja2: 2.10 libgit2: Not Installed M2Crypto: Not Installed Mako: Not Installed msgpack: 0.5.6 msgpack-pure: Not Installed mysql-python: Not Installed pycparser: Not Installed pycrypto: 2.6.1 pycryptodome: 3.6.1 pygit2: Not Installed Python: 3.7.3 (default, Jan 22 2021, 20:04:44) python-gnupg: Not Installed PyYAML: 3.13 PyZMQ: 17.1.2 smmap: 2.0.5 timelib: Not Installed Tornado: 4.5.3 ZMQ: 4.3.1

System Versions: dist: debian 10 buster locale: UTF-8 machine: x86_64 release: 4.19.0-14-amd64 system: Linux version: Debian GNU/Linux 10 buster

Pillar / config used

Trying to add

              - location = /stub_status:
                  stub_status

Bug details

Describe the bug

The rendered seems to expect something after the first word, but if that's true for most, the stub_status command is standing alone.

Steps to reproduce the bug

Use the above YAML, and observe.

Expected behaviour

The rendering should not fail because there is no value after stub_status.

Attempts to fix the bug

Solution is to use

- location = /stub_status:
    - stub_status: 'on'

But, the 'on' is not necessary as per the nginx doc.

Additional context

Ideally, it should be added in the pillar.example so that people do not struggle...