feat(debian): use keyrings instead of key_ids

javierbertoli commented 2 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[X] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[X] [docs] Documentation changes
[X] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Debian family is deprecating the use of GPG keys (managed through apt-key) in favor of keyrings. This PR adds keyrings both for nginx and passenger when installed from official repositories, and rewrite the sources.list file accordingly.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[X] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[X] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

myii commented 2 years ago

Merged, thanks for the PR, @javierbertoli.

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 2.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

myii commented 2 years ago

@baby-gnu Something that might be interesting to discuss in one of the working group meetings (a potential improvement to the system.rb library):

https://github.com/saltstack-formulas/nginx-formula/blob/ec9559b2c362a1ac424d49d4b5ca64a814ec1772/test/integration/passenger/controls/repository.rb#L8-L16

saltstack-formulas / nginx-formula