saltstack-formulas / nginx-formula

Nginx Salt Formula
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
163 stars 421 forks source link

Enable configurations by default #300

Open tacerus opened 1 year ago

tacerus commented 1 year ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No - whilst the default behavior technically changes, practically the default behavior before this change would print an error message, hence nobody could have been using it so far.

Related issues and/or pull requests

Describe the changes you're proposing

On distributions without separate available/enabled directories it feels unnecessary having to declared enabled: true in every configuration block. I propose "enabling" configurations by default unless specified otherwise, instead of printing an error about enabled missing from the dict.

Pillar / config required to test the proposed changes

nginx:
  servers:
    managed:
      general.conf:
        available_dir: /etc/nginx/conf.d
        config:
        - server_names_hash_bucket_size: 128

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

n/a