Closed smitelli closed 5 years ago
@smitelli ow, merged in the wrong order, can you please rebase?
@aboe76 All done. Had a minor conflict in node/init.sls
; may want to give it a sanity check.
Thanks for the work @smitelli @aboe76
BTW I created two issues based on the Travis CI.
node.pkg
state is tested (https://github.com/saltstack-formulas/node-formula/issues/43).
In an environment with the option
pillar_raise_on_missing: True
and pillar data which defines only some keys, this formula fails with messages like:(In this case, the pillar had set
install_from_ppa: True
and did not defineinstall_from_source
and friends.)Fixing it requires either explicitly defining every pillar key that the formula checks, or modifying the source of the formula itself. Having tried the former, now I'm trying the latter. This PR adds a falsy default value (the empty string
''
) to every instance ofpillar.get
, behaving like it would ifpillar_raise_on_missing
were not set.