saltstack-formulas / node-formula

Manage node.js with SaltStack
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
26 stars 104 forks source link

feat(formula): store macros.jinja in subdir, trigger major release #49

Closed noelmcloughlin closed 4 years ago

noelmcloughlin commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Mark #48 as breaking change so the major release is triggered.

And close: #43

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

noelmcloughlin commented 4 years ago

That's done @myii thanks for reviewing and patience getting this completed.

pull-assistant[bot] commented 4 years ago
Score: 0.91

Best reviewed: commit by commit


Optimal code review plan (3 warnings)

     chore(symlinks): keep legacy interface support      chore(symlinks): keep legacy interface support      Merge branch 'template'
Merge branch 'master' of http://github.com/saltstack-formulas/node-for...
> `.travis.yml` 88% changes removed in feat(semantic-releas... > `kitchen.yml` 72% changes removed in Merge branch 'master...
     feat(new structure): retrospectively trigger major semantic release      chore(yaml): change none to null
feat(semantic-release): standardise for this formula
> `.travis.yml` 80% changes removed in Merge branch 'master... > `kitchen.yml` 43% changes removed in Merge branch 'master...
     docs(readme): add depth one
Merge branch 'master' of https://github.com/saltstack-formulas/node-fo...
> `AUTHORS.md` 50% changes removed in Merge branch 'master...
     Merge branch 'master' into breaking      chore(conflict): fix a conflict

Powered by Pull Assistant. Last update c0be4b2 ... b333a69. Read the comment docs.

noelmcloughlin commented 4 years ago

Travis CI is passed and I fixed conflicts with master again

noelmcloughlin commented 4 years ago

@myii can this be merged.

myii commented 4 years ago

Thanks, @noelmcloughlin.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: