search

saltstack-formulas / ntp-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
23 stars 158 forks source link

ntp.conf files should have server instead of servers #17

Closed timwsuqld closed 9 years ago

timwsuqld commented 9 years ago

Following the example pillar file gives an invalid ntp.conf for NTP NG. Need to be server instead of servers in the pillar config

gravyboat commented 9 years ago

Good catch, thanks.

wwentland commented 9 years ago

The pillar referenced is actually ntp:servers so only the example is wrong, not the pillar key: https://github.com/saltstack-formulas/ntp-formula/blob/master/ntp/ntp.conf#L4

gravyboat commented 9 years ago

@babilen Thanks for weighing in, probably shouldn't look at these late in the evening. @timwsuqld Do you want to update that?

timwsuqld commented 9 years ago

@babilen I'm only referring to the NTP NG config, not the older NTP config. https://github.com/saltstack-formulas/ntp-formula/blob/master/ntp/ng/files/ntp.conf uses the pillar key to generate it's config. You are referring to the NTP config not the NTP NG config.

gravyboat commented 9 years ago

Alright I'm going to merge this then, thanks guys.

wwentland commented 9 years ago

Yay for consistency! ;)