Prevent random order of declarations

saltstack-formulas / ntp-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

23 stars 158 forks source link

Prevent random order of declarations #42

Closed alxwr closed 5 years ago

alxwr commented 5 years ago

when running salt-ssh on a minion with Python 3.5.2.

Tested on:

master: Salt 2019.2; Python 3.6; FreeBSD 11.2
minion: Salt 2019.2 (from master); Python 3.5.2; Ubuntu 16.04

alxwr commented 5 years ago

@myii If we don't want to support Python <3.6, please reject this PR.

myii commented 5 years ago

@alxwr So I didn't quite follow in Slack after Daniel's responses. Is this still something required or not?

myii commented 5 years ago

@alxwr Sorry, I missed your comment somehow. We need to keep supporting older Python versions, so this is a good PR. Are there any side effects when not using salt-ssh? @aboe76 Any thoughts about this?

aboe76 commented 5 years ago

@alxwr py2 is still supported so we need to be backwards compatible...

alxwr commented 5 years ago

@aboe76 @myii py3.5 has unsorted dicts. 2.7 is not affected. This PR may solve the issue for this formula, but I would not want to implement support for 3.5 into all formulas. :-)

myii commented 5 years ago

Brilliant, thanks @alxwr -- merged.