saltstack-formulas / ntp-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
23 stars 158 forks source link

refactor(ng/init.sls): use `grains.get` to detect containers #45

Closed myii closed 5 years ago

myii commented 5 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Follow-up for #44.

Describe the changes you're proposing

Use grains.get directly rather than via. config.get. Also increase the list of containers that are checked for, based on discussions in the wg.

Pillar / config required to test the proposed changes

Covered by existing setup.

Debug log showing how the proposed changes work

As shown in Travis.

Documentation checklist

Testing checklist

Additional context

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.19.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: