saltstack-formulas / ntp-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
23 stars 158 forks source link

test(service): add helper state to run service in containers #47

Closed myii closed 3 years ago

myii commented 3 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Some distros do not start the service if virtualization is detected, so we force the service to start to test the formula.

Includes a revert for commit 8711b24bb87db443594c1f9bb30da62d7fa4dc37, which is no longer required as a workaround for Kitchen testing due to improved method.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

myii commented 3 years ago

Self-merge, essentially the same fix as https://github.com/saltstack-formulas/rng-tools-formula/pull/5.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 0.20.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: