search

saltstack-formulas / openssh-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
90 stars 297 forks source link

Fix invalid require_in sshd_config for key states #131

Closed tmeneau closed 6 years ago

tmeneau commented 6 years ago

The purpose of this pull request is to allow using the config.sls state exclusively to configure keys (RSA, DSA, etc...) without managing the sshd_config (see issue #130).

This is a pretty simple change that adds conditional evaluation to the require_ins applied to the key management states to make the key management states a requisite of the sshd_config management state.

@aboe76 @alxwr -- are either of you free to review this?

javierbertoli commented 6 years ago

@tmeneau you seem to have missed an if block around these lines?

Other than that, it LGTM?

tmeneau commented 6 years ago

Thanks for the review @javierbertoli!

I actually didn't bother to add a conditional to those lines since sshd_config (which is used to compute the new manage_sshd_config variable) must be defined for that last state to exist at all.

Would you be willing to merge this in?

tmeneau commented 6 years ago

Thanks @javierbertoli!

javierbertoli commented 6 years ago

Thanks to you :smile: