search

saltstack-formulas / openssh-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
90 stars 297 forks source link

Resolve gem dependencies across "supported" environments #142

Closed scub closed 5 years ago

scub commented 5 years ago

This hacky PR attempts to keep serverspec running natively for the distributions where busser-serverspec hasn't been lost entirely; ie: (from suite: ubuntu-14

-----> Installing Busser (busser)
Fetching: thor-0.19.0.gem (100%)
Fetching: busser-0.7.1.gem (100%)
       Successfully installed thor-0.19.0
       Successfully installed busser-0.7.1
       2 gems installed
-----> Installing Busser plugin: busser-serverspec
       /usr/lib/ruby/1.9.1/rubygems/installer.rb:390:in `ensure_required_ruby_version_met': rake requires Ruby version >= 2.0.0. (Gem::InstallError)

Currently the platforms this fixes tests for are:

More specifically the failure this addresses is:

-----> Installing Serverspec..
Fetching: diff-lcs-1.3.gem (100%)
Fetching: rspec-mocks-3.8.0.gem (100%)
Fetching: rspec-expectations-3.8.2.gem (100%)
Fetching: rspec-3.8.0.gem (100%)
Fetching: rspec-its-1.2.0.gem (100%)
Fetching: multi_json-1.13.1.gem (100%)
Fetching: sfl-2.3.gem (100%)
Fetching: net-telnet-0.1.1.gem (100%)
Fetching: net-ssh-5.0.0.rc2.gem (100%)
       /usr/lib/ruby/2.1.0/rubygems/installer.rb:543:in `ensure_required_ruby_version_met': net-ssh requires Ruby version >= 2.2.6. (Gem::InstallError)
scub commented 5 years ago

@noelmcloughlin / @aboe76 - what are your thoughts here, is there a better way to approach keeping tests healthy across supported platforms?

javierbertoli commented 5 years ago

@scub I think that moving testing to inspec, which is the successor of serverspec would be trivial and, perhaps, a better approach? It's fully supported by kitchen-test and we've been using it successfully in many formulas with no hassle.

It sems that

will do the trick?

noelmcloughlin commented 5 years ago

I have no opinion either way. But I think Ubuntu-14 is EOL. So If you see opportunity to update list of targets that would be nice.

aboe76 commented 5 years ago

Removing EOL distributions from testing is a good thing, I don't have a opinion on serverspec vs inspec, but if inspec is the successor go for it.

myii commented 5 years ago

@noelmcloughlin above:

I have no opinion either way. But I think Ubuntu-14 is EOL. So If you see opportunity to update list of targets that would be nice.

https://en.wikipedia.org/wiki/Ubuntu_version_history#Ubuntu_14.04_LTS_(Trusty_Tahr):

Normal LTS support is set to continue until 30 April 2019, after which Extended Security Maintenance will be available to Ubuntu Advantage customers and as a separate commercial purchase, as was the case previously with 12.04.

Standard EOL is in 3 months time but may need to allow for Extended Security Maintenance.

@aboe76 above:

Removing EOL distributions from testing is a good thing ...

Is there a policy about allowing for things like Extended Security Maintenance?

aboe76 commented 5 years ago

@scub merged it, @noelmcloughlin and @myii I don't think there is a policy....it's what we as a community make of it.