saltstack-formulas / openssh-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
90 stars 297 forks source link

test(inspec): add tests based on existing Serverspec tests #168

Closed myii closed 4 years ago

myii commented 4 years ago

test(pillar): remove deprecated option and disabled method

/home/kitchen/__salt.tmp.9rqda9ha line 15: Deprecated option UsePrivilegeSeparation
Disabled method "keyboard-interactive" in AuthenticationMethods list "publickey,keyboard-interactive"
AuthenticationMethods cannot be satisfied by enabled authentication methods

test(pillar): use same SSH options as used by Travis

       [SSH] connection failed, retrying in 1 seconds (#<Net::SSH::AuthenticationFailed: Authentication failed for user kitchen@localhost>)
       [SSH] connection failed, retrying in 1 seconds (#<Net::SSH::AuthenticationFailed: Authentication failed for user kitchen@localhost>)
       [SSH] connection failed, retrying in 1 seconds (#<Net::SSH::AuthenticationFailed: Authentication failed for user kitchen@localhost>)
       [SSH] connection failed, retrying in 1 seconds (#<Net::SSH::AuthenticationFailed: Authentication failed for user kitchen@localhost>)
$$$$$$ [SSH] connection failed, terminating (#<Net::SSH::AuthenticationFailed: Authentication failed for user kitchen@localhost>)
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: 1 actions failed.
>>>>>>     Failed to complete #verify action: [Transport error, can't connect to 'ssh' backend: SSH session could not be established] on default-debian-10-develop-py3

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.42.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

daks commented 4 years ago

oh already merged, didn't had time to review it. Just a question: I thought the plan was to move from serverspec to inspec but I'm not sure this was the purpose of this PR because serverspec tests are still there.

myii commented 4 years ago

@daks I've left the Serverspec tests there for the time being, until the Vagrant issues are resolved. It all works fine together in the meanwhile.