PR progress checklist (to be filled in by reviewers)
[x] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[x] Reviews completed
What type of PR is this?
Primary type
[ ] [build] Changes related to the build system
[x] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
Secondary type
[ ] [docs] Documentation changes
[x] [test] Adding missing or correcting existing tests
Does this PR introduce a BREAKING CHANGE?
No.
Related issues and/or pull requests
Describe the changes you're proposing
Before:
↺ openssh package: should be installed
↺ The `package` resource is not supported on your OS yet.
× openssh configuration: should match desired lines (2 failed)
✔ File /etc/ssh/sshd_config is expected to be file
✔ File /etc/ssh/sshd_config is expected to be owned by "root"
× File /etc/ssh/sshd_config is expected to be grouped into "root"
expected `File /etc/ssh/sshd_config.grouped_into?("root")` to return true, got false
✔ File /etc/ssh/sshd_config mode is expected to cmp == "0644"
✔ File /etc/ssh/sshd_config content is expected to include "ChallengeResponseAuthentication no"
✔ File /etc/ssh/sshd_config content is expected to include "X11Forwarding yes"
✔ File /etc/ssh/sshd_config content is expected to include "PrintMotd no"
✔ File /etc/ssh/sshd_config content is expected to include "AcceptEnv LANG LC_*"
✔ File /etc/ssh/sshd_config content is expected to include "Subsystem sftp /usr/lib/openssh/sftp-server"
✔ File /etc/ssh/sshd_config content is expected to include "UsePAM yes"
✔ File /etc/ssh/ssh_config is expected to be file
✔ File /etc/ssh/ssh_config is expected to be owned by "root"
× File /etc/ssh/ssh_config is expected to be grouped into "root"
expected `File /etc/ssh/ssh_config.grouped_into?("root")` to return true, got false
✔ File /etc/ssh/ssh_config mode is expected to cmp == "0644"
✔ File /etc/ssh/ssh_config content is expected to include "Host *"
✔ File /etc/ssh/ssh_config content is expected to include " GSSAPIAuthentication yes"
✔ File /etc/ssh/ssh_config content is expected to include " HashKnownHosts yes"
✔ File /etc/ssh/ssh_config content is expected to include " SendEnv LANG LC_*"
✔ openssh service: should be running and enabled
✔ Service sshd is expected to be enabled
✔ Service sshd is expected to be running
Profile Summary: 1 successful control, 1 control failure, 1 control skipped
Test Summary: 18 successful, 2 failures, 1 skipped
After:
↺ openssh package: should be installed
↺ The `package` resource is not supported on your OS yet.
✔ openssh configuration: should match desired lines
✔ File /etc/ssh/sshd_config is expected to be file
✔ File /etc/ssh/sshd_config is expected to be owned by "root"
✔ File /etc/ssh/sshd_config is expected to be grouped into "wheel"
✔ File /etc/ssh/sshd_config mode is expected to cmp == "0644"
✔ File /etc/ssh/sshd_config content is expected to include "ChallengeResponseAuthentication no"
✔ File /etc/ssh/sshd_config content is expected to include "X11Forwarding yes"
✔ File /etc/ssh/sshd_config content is expected to include "PrintMotd no"
✔ File /etc/ssh/sshd_config content is expected to include "AcceptEnv LANG LC_*"
✔ File /etc/ssh/sshd_config content is expected to include "Subsystem sftp /usr/lib/openssh/sftp-server"
✔ File /etc/ssh/sshd_config content is expected to include "UsePAM yes"
✔ File /etc/ssh/ssh_config is expected to be file
✔ File /etc/ssh/ssh_config is expected to be owned by "root"
✔ File /etc/ssh/ssh_config is expected to be grouped into "wheel"
✔ File /etc/ssh/ssh_config mode is expected to cmp == "0644"
✔ File /etc/ssh/ssh_config content is expected to include "Host *"
✔ File /etc/ssh/ssh_config content is expected to include " GSSAPIAuthentication yes"
✔ File /etc/ssh/ssh_config content is expected to include " HashKnownHosts yes"
✔ File /etc/ssh/ssh_config content is expected to include " SendEnv LANG LC_*"
✔ openssh service: should be running and enabled
✔ Service sshd is expected to be enabled
✔ Service sshd is expected to be running
Profile Summary: 2 successful controls, 0 control failures, 1 control skipped
Test Summary: 20 successful, 0 failures, 1 skipped
Pillar / config required to test the proposed changes
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Before:
After:
Pillar / config required to test the proposed changes
Tested with the following
kitchen.vagrant.yml
:Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context