saltstack-formulas / openssh-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
90 stars 297 forks source link

Ensure the tab replacement happens before the edit #178

Closed OrangeDog closed 4 years ago

OrangeDog commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

162 can still happen under some circumstances

Describe the changes you're proposing

Add a requisite to ensure states are applied in the correct order

Pillar / config required to test the proposed changes

include:
  - openssh.config_ini

/usr/sbin/sshd -t:
  cmd.run:
    - onchanges:
      - ini: sshd_config-with-ini
    - require_in:
      - service: openssh

Documentation checklist

Testing checklist

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     Ensure the tab replacement happens before the edit

Powered by Pull Assistant. Last update 562ccea ... 562ccea. Read the comment docs.

myii commented 4 years ago

Merged with an adjusted commit message:

fix(config_ini): ensure the tab replacement happens before the edit

Thanks for the fix, @OrangeDog.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.43.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: