saltstack-formulas / openssh-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
90 stars 297 forks source link

feat(ci): update ci to latest standards #182

Closed baby-gnu closed 4 years ago

baby-gnu commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

I update the travis and kitchen test matrix to latest template-formula standard and fix few things for compatibility:

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     feat(ci): update travis and kitchen to latest formula standards      fix(jinja): encode context as json      fix(inspec): the package name for Arch is openssh

Powered by Pull Assistant. Last update 7752132 ... 6b7d8df. Read the comment docs.

myii commented 4 years ago

@baby-gnu Thanks for this PR. I'm going to have to run this through the ssf-formula but there's a bit of a backlog there with other PRs that have already been merged in the org. Besides, I can see a couple of issues but I'll let the review take place with the commit that is automatically created. Please give me a couple of days for this, thanks.

myii commented 4 years ago

@baby-gnu This is the diff generated by the ssf-formula: https://github.com/saltstack-formulas/openssh-formula/commit/71fe2f3061ca6aa6533877db16d3d7fb8f60d535. It would be more appropriate to amend 10dc1346971235d0b6b633b6f5c98cbf62d54087 with this instead of adding this on top. There is a slight difference in the matrix since I'm reusing one of the available YAML node anchors.

I've also tested this PR against all of the unique platforms and everything is working fine:

baby-gnu commented 4 years ago

This is the diff generated by the ssf-formula: 71fe2f3. It would be more appropriate to amend 10dc134 with this instead of adding this on top. There is a slight difference in the matrix since I'm reusing one of the available YAML node anchors.

Interesting, I copied the travis.yml from template-formula, so the new matrix in openssh-formula should be what users will have when doing a ./bin/convert-formula.sh.

If I understand your proposed diff, we should remove tests for the version 3000?

I've also tested this PR against all of the unique platforms and everything is working fine:

Great to read that.

baby-gnu commented 4 years ago

Great, it's working.

myii commented 4 years ago

Merged, excellent work @baby-gnu!


Checked using https://github.com/myii/ssf-formula/pull/239.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: