Closed baby-gnu closed 4 years ago
Best reviewed: commit by commit
Powered by Pull Assistant. Last update 7752132 ... 6b7d8df. Read the comment docs.
@baby-gnu Thanks for this PR. I'm going to have to run this through the ssf-formula
but there's a bit of a backlog there with other PRs that have already been merged in the org. Besides, I can see a couple of issues but I'll let the review take place with the commit that is automatically created. Please give me a couple of days for this, thanks.
@baby-gnu This is the diff generated by the ssf-formula
: https://github.com/saltstack-formulas/openssh-formula/commit/71fe2f3061ca6aa6533877db16d3d7fb8f60d535. It would be more appropriate to amend 10dc1346971235d0b6b633b6f5c98cbf62d54087 with this instead of adding this on top. There is a slight difference in the matrix since I'm reusing one of the available YAML node anchors.
I've also tested this PR against all of the unique platforms and everything is working fine:
This is the diff generated by the
ssf-formula
: 71fe2f3. It would be more appropriate to amend 10dc134 with this instead of adding this on top. There is a slight difference in the matrix since I'm reusing one of the available YAML node anchors.
Interesting, I copied the travis.yml
from template-formula, so the new matrix in openssh-formula
should be what users will have when doing a ./bin/convert-formula.sh
.
If I understand your proposed diff, we should remove tests for the version 3000
?
I've also tested this PR against all of the unique platforms and everything is working fine:
Great to read that.
Great, it's working.
:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
I update the travis and kitchen test matrix to latest
template-formula
standard and fix few things for compatibility:Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context