test(config_spec): verify the generation of /etc/ssh/ssh_known_hosts

baby-gnu commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[x] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[x] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

We test the generation of /etc/ssh/ssh_known_hosts.

Pillar / config required to test the proposed changes

It's already included in test/salt/pillar/default.sls.

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan

test(config_spec): verify /etc/ssh/ssh_known_hosts ci(kitchen): execute `openssh.known_hosts` state fix(known_hosts): dig package does not install on Arch

Powered by Pull Assistant. Last update 06ef24b ... 0b667cb. Read the comment docs.

myii commented 4 years ago

Thanks @baby-gnu. Technically, I wouldn't consider this as a new feature and so would suggest adjusting the commit message types (also a typo needs to be fixed):

-feat(inspec): verify /etc/ssh/ssk_known_hosts
+test(config_spec): verify /etc/ssh/ssh_known_hosts

-feat(kitchen): execute `openssh.known_hosts` state 
+ci(kitchen): execute `openssh.known_hosts` state

baby-gnu commented 4 years ago

Ok, thanks for the review, I'll do that

myii commented 4 years ago

Excellent work, @baby-gnu.

Checked using https://github.com/myii/ssf-formula/pull/241.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / openssh-formula