saltstack-formulas / openssh-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
90 stars 297 forks source link

fix(map): `path_join` can be used only for local file access #190

Closed baby-gnu closed 4 years ago

baby-gnu commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

186

Describe the changes you're proposing

On windows machines, the path_join build wrong URL by using backslash as separator.

URL used for fileserver access must use only slashes /.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix(map): `path_join` can be used only for local file access

Powered by Pull Assistant. Last update 3845d5f ... 3845d5f. Read the comment docs.

javierbertoli commented 4 years ago

Thanks, @baby-gnu !

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 2.0.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: