saltstack-formulas / openssh-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
90 stars 297 forks source link

test(inspec): use static hostname in mapdata #195

Closed baby-gnu closed 4 years ago

baby-gnu commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Do not modify _mapdata content to match hostname and force the hostname in kitchen.yml instead.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ci(kitchen): force the hostname of the containers      test(inspec): no more need to mangle mapdata for hostname      test(share): standardise structure

Powered by Pull Assistant. Last update 208f873 ... 15241d3. Read the comment docs.

baby-gnu commented 4 years ago

Thanks a lot.

myii commented 4 years ago

Thanks a lot.

@baby-gnu You're welcome -- merged.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 2.0.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: