saltstack-formulas / openssh-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
90 stars 297 forks source link

fix(pillar): `tofs` must not be under `mine_functions` #196

Closed baby-gnu closed 3 years ago

baby-gnu commented 3 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

164

Describe the changes you're proposing

The debug output of test jobs don't show the use of TOFS as it should and the pillar.example show that tofs is under mine_functions instead of openssh.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Before:

       sshd_config:
         file.managed:
           - name: /etc/ssh/sshd_config
           - source: 
             - salt://openssh/files/example.net/sshd_config
             - salt://openssh/files/Debian/sshd_config
             - salt://openssh/files/default/sshd_config
           - template: jinja

After:

       sshd_config:
         file.managed:
           - name: /etc/ssh/sshd_config
           - source: 
             - salt://openssh/files/example.net/alt_sshd_config
             - salt://openssh/files/example.net/sshd_config
             - salt://openssh/files/Debian/alt_sshd_config
             - salt://openssh/files/Debian/sshd_config
             - salt://openssh/files/default/alt_sshd_config
             - salt://openssh/files/default/sshd_config
           - template: jinja

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 3 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     test(inspec): `_mapdata` files should have `tofs` configuration      fix(pillar): `tofs` must not be under `mine_functions`

Powered by Pull Assistant. Last update 5e9033f ... c0d5052. Read the comment docs.

myii commented 3 years ago

Merged, thanks for this @baby-gnu.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 2.0.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: