search

saltstack-formulas / openssh-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
90 stars 297 forks source link

Add variables for file owner and mode #86

Closed amendlik closed 7 years ago

amendlik commented 7 years ago

Permit customization of file owner and mode for ssh_config and sshd_config. I added this because the current default is 644, but CIS benchmarks recommend 600.

0xf10e commented 7 years ago

As long as ssh_config_mode: '600' doesn't end up in the defaults or pillar.example it's fine with me. This would prevent any global configuration of a host's OpenSSH client - and is a rather strange idea in my opinion.

amendlik commented 7 years ago

This PR does not change the current behavior in any way. It just makes it possible for the user to configure some hard coded values.

@0xf10e is right about ssh_config_mode: '600'. The CIS benchmark only specifies the permissions for sshd_config

aboe76 commented 7 years ago

@amendlik can you then please revert the permissions on ssh_config, to be like the defaults in the kitchen.yml, somebody could think that's a good idea and see it as acceptable.

0xf10e commented 7 years ago

Looks good to me

aboe76 commented 7 years ago

@amendlik could you please rebase, then I will merge it.

aboe76 commented 7 years ago

Thanks, merging now.

alxwr commented 7 years ago

66c954e sets correct default values for OpenBSD and FreeBSD and repaces root_group.