search

saltstack-formulas / openvpn-formula

Setup and configure openvpn server and client.
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
35 stars 114 forks source link

Update example pillar with quoted "yes" for comp-lzo #117

Closed cmclaughlin closed 5 years ago

cmclaughlin commented 5 years ago

This avoids Salt's yaml/json casting to bool.

myii commented 5 years ago

@cmclaughlin Note, this repo uses semantic-release, so commit message formatting is significant. commitlint shows the problems:

https://travis-ci.com/saltstack-formulas/openvpn-formula/jobs/231957920#L274:

✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

So this would be appropriate:

-Update example pillar with quoted "yes" for comp-lzo
+docs(pillar.example): update with quoted "yes" for comp-lzo

Since you've just fixed this in the second commit, I'll just squash this PR and fix the commit message manually. Not a problem at all and thanks for the contribution -- I've merged it.

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.14.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: