search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 231 forks source link

Added missing settings for ubuntu. #107

Closed stokbaek closed 8 years ago

gravyboat commented 8 years ago

@aboe76 @babilen Could you please take a look at this?

aboe76 commented 8 years ago

@stokbaek, I don't get the change did something not work ? As fas I could see, it should be using first some ubuntu specific mapping for the packages, and then because ubuntu also uses os_family debian, reuse those settings and merge it , for the minion...

It looks like your changes, will duplicate all settings ubuntu and debian, am I correct?

stokbaek commented 8 years ago

@aboe76 as it will return true to the if statement on line 289 will it never get to a debian section as this is in an else statement to this if statement.

aboe76 commented 8 years ago

Tested the new map.jinja on our debian machines no problem. Can somebody check this on ubuntu?

aboe76 commented 8 years ago

ran a ubuntu xenial vm to test this and it also works without a problem, merging this.

gravyboat commented 8 years ago

Thanks @aboe76.