search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 231 forks source link

Make php.ng.maps.jinja work for php5 on Debian #123

Closed vquie closed 7 years ago

vquie commented 7 years ago

Since php5 installs in different location, this formula was not working. I added an if statement to determine the correct dir.

This change only affects Debian with php5.

aboe76 commented 7 years ago

You are correct, but the logic on the phpng_version should only be found if you use an external repo has been set on Debian, looks like the the first if / elif / else statement is only on OS not on external repo yes or no.

see line https://github.com/vquiering/php-formula/blob/51984f06de55453022bc8a048514ace191fb959b/php/ng/map.jinja#L1730

that's why there is #116

vquie commented 7 years ago

Thanks for clearing this up. I guess the whole map.jinja needs to be redone then. With Debian we don't even pass the first if statement in line 4. With https://github.com/saltstack-formulas/php-formula/pull/122 we made it at least work on Debian with php >= 7.0

aboe76 commented 7 years ago

@vquiering thanks for this