search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 231 forks source link

Remove env from ppa definition #164

Closed Seldaek closed 5 years ago

Seldaek commented 5 years ago

Using the latest version of this repo on Ubuntu 18.04 and installing php.ng with the ppa enabled and php 7.3 as target, I get the following:

          ID: php_ppa_fpm
    Function: pkgrepo.managed
      Result: False
     Comment: Failed to configure repo 'php_ppa_fpm': _call_apt() got multiple values for keyword argument 'env'
     Started: 12:30:59.229400
    Duration: 72.24 ms
     Changes:

image

I am not sure what causes this, I dug in salt source a bit but couldn't figure it out. Renaming to env or removing the env entirely both make it work.

aboe76 commented 5 years ago

@Seldaek on which salt version did you get this error?

Seldaek commented 5 years ago

It's a fresh install on Ubuntu 18.04 so getting salt 2019.2.0 (Fluorine)

aboe76 commented 5 years ago

@Seldaek this is I think the reason:

https://docs.saltstack.com/en/develop/topics/releases/fluorine.html#configurable-module-environment

but it should have been deprecated in carbon version: https://docs.saltstack.com/en/develop/topics/releases/carbon.html#general-deprecations

So I think removing the env is the right thing to do. but please reread the last deprecations, because they wrote it down in such a away that isn't easy to understtand.