search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 231 forks source link

apache2/ini: fix config merge #193

Open ze42 opened 5 years ago

ze42 commented 5 years ago

fix merge like other ini files

myii commented 5 years ago

Thanks for this, @ze42. A couple of things to consider:

This repo now uses semantic-release, which means that commit messages are significant. The explanation is available in the log:

✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

Only the commit title would need to be modified, the body can stay as-is. So a suggestion:

-apache2/ini: fix config merge
+fix(apache2/ini): fix config merge

The second thing is that this will probably have to be merged after #183. We've caused the author of that PR far too much hassle every time we merge a PR, so this PR will have a simple adjustment afterwards in comparison. If you're a user of this formula, it would be great if you could test #183 at your end so that we can get on with merging it.

myii commented 5 years ago

@ze42 Apologies, with the merge of #183, this will need amending before it can be reviewed and merged.

n-rodriguez commented 5 years ago

Hi there! Any news?