saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 232 forks source link

fix(modules): add missing variable setting #208

Closed javierbertoli closed 4 years ago

javierbertoli commented 4 years ago

should fix #207

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

207

Describe the changes you're proposing

A missing variable setting in the modules.sls iterator for the modules is making the modules.sls fail to install modules.

Pillar / config required to test the proposed changes

See #207

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

AmitChotaliya commented 4 years ago

@javierbertoli It is still not working. Here's what I tried.

- git://github.com/netmanagers/php-formula:
    - base: fix-issue-207-add-missing-var-to-modules.sls
javierbertoli commented 4 years ago

No need for this PR