SUSE: Update to php8 + Leap 15.4

tacerus commented 1 year ago

PR progress checklist (to be filled in by reviewers)

[x] Changes to documentation are appropriate (or tick if not required)
[x] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Version update.

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[x] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[x] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No, assuming no-one uses and updates the formula on an outdated operating system.

Related issues and/or pull requests

Describe the changes you're proposing

Set default PHP package versions on SUSE based operating systems to 8. Update Kitchen to use openSUSE Leap 15.4 instead of 15.3.

Pillar / config required to test the proposed changes

n/a

Debug log showing how the proposed changes work

Output too long for GitHub.

Documentation checklist

[x] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[x] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[x] Updated the relevant test pillar.

Additional context

tacerus commented 1 year ago

Not sure why the installation of salt-lint in the pre-commit pipeline fails.

tacerus commented 1 year ago

Any suggestions on preventing php_fpm_ini_config from being run (or alternatively on keeping the file empty) by default? The default ini map has lots of options which conflict with the default extension specific ini files shipped in SUSE packages - those also generally work out of the box, hence the custom ini should only be installed if needed by the user. I tried to add

                'ini': {
                    'defaults': {},
                },

and

               fpm: {
                    'config': {
                       'ini': {
                          'opts': {},
                          'settings': {},
                       },
                    },
              }

to the Suse default map but it still writes the global defaults to the ini file.

Of course, I could have left the old ini location, which was never read by the currently packaged PHP-FPM service in the first place... but I would rather disable it than keep a useless file. :-)

saltstack-formulas / php-formula