search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 231 forks source link

php.composer should ensure that curl is installed #39

Open wwentland opened 9 years ago

wwentland commented 9 years ago

The php.composer state requires curl to be installed, but does not ensure it in any way.

gravyboat commented 9 years ago

Hmm, should the composer state handle that? Or should it simply include a state coming from another formula?

wwentland commented 9 years ago

I am not sure and would, personally, prefer a dependency on a different formula in general. This "curl-formula" would be most trivial though and it would probably make sense to simply include a "php_curl_pkg" pkg.installed state. Either way I wouldn't mind implementing this, but didn't get around to do it when I ran into this issue.

What do you think @gravyboat ? We will probably have various formulas that require some tool to be present and we would have a lot of work if we were to aim for a formula for every single one of them.

ross-p commented 9 years ago

@babilen good catch.

I agree with you that installing curl is minimal and probably better done with something like php_curl_pkg rather than adding an external dependency to a simple curl-formula.

gravyboat commented 9 years ago

@babilen Yeah as much as I hate to say it, I'd prefer if we just installed the dependency for the formula in the formula. I'm imagining some new user going 'okay I need the curl formula, oh now I need the os install formula' and so on and so forth. Whiteinge was kind enough to already create https://github.com/saltstack-formulas/php-formula/blob/master/php/curl.sls so I say just update the include in the php.composer state. Especially since that sort of sets the standard and it already exists.