search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 231 forks source link

php.ng use_ppa doesnt work as expected #61

Closed cybacolt closed 9 years ago

cybacolt commented 9 years ago

merged PR in reference to https://github.com/saltstack-formulas/php-formula/issues/36 checks use_ppa for its absence, but does not check value.

if you set use_ppa: False, it installs the ppa anyway.

gravyboat commented 9 years ago

It's checking for the existence of the use_ppa value at all so I can see how this would be problematic, @seldaek concerns over changing this to a default set of False and then checking for False? This is in relation to #38.

gravyboat commented 9 years ago

@cybacolt If you want to prep a PR to resolve this for a default setting of False, and then the corrected check I'd be happy to merge it in if @Seldaek doesn't have any concerns.

cybacolt commented 9 years ago

@gravyboat @Seldaek hopefully this will do the trick.... (tests ok for me)

Seldaek commented 9 years ago

Seems good to me, I think this can be closed.