search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 231 forks source link

ubuntu 14.04, default hhvm pid file path incorrect #65

Open cybacolt opened 9 years ago

cybacolt commented 9 years ago

from /etc/init.d/hhvm: PIDFILE=/var/run/hhvm/pid

from the php formula map php/ng/map.jinja: ('pid', '/var/run/hhvm.pid'),

this causes hhvm not to start by default unless you add to your pillar:

  ng:
    lookup:
      hhvm:
        server:
          pid: '/var/run/hhvm/pid'

not sure if this is easily changable - other distros may break if your change the default pid pathing?

gravyboat commented 9 years ago

Seems like something that we should add to the map.jinja for each distro, then merge that with the pillar data.

Edit: Actually it looks like that was already done, Is this not getting merged correctly or something?

cybacolt commented 9 years ago

yeah, it its mapping per distro, but the value is still wrong for 'Debian'

gravyboat commented 9 years ago

I'd say prep a PR for the debian fix then, could have been someone just copy pasta'd it in an effort to save time.