Only add ppa if it doesn't exist.

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

57 stars 231 forks source link

Only add ppa if it doesn't exist. #72

Closed zls closed 8 years ago

zls commented 8 years ago

This comit is in addition to pull request #70. The add-apt-repository command will only be run when the ppa has not yet been added.

gravyboat commented 8 years ago

Can you please explain to me what use case this resolves? When the ppa is added a second time it should be detected that it's already been added and skipped.

zls commented 8 years ago

With pull request #70 the ppa is added manually with add-apt-repository. This shows as changes on subsequent salt runs, even though nothing has changed. Additionally a commented deb-src line is added on each run.

gravyboat commented 8 years ago

Ugh I totally forgot that happens. Thanks for the PR, hopefully they'll resolve https://github.com/saltstack/salt/issues/23543.