search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 231 forks source link

Empty php:ng:fpm:pools causes cryptic error message #73

Closed johnkeates closed 8 years ago

johnkeates commented 8 years ago

If you have FPM configuration files split in re-usable pieces and end up with a FPM config that has no pools for a minion (I know, it's not useful for FPM, bear with me), Salt fails with a rather nondescript message about null not being iterable. There are no pointers as to which state, file or line this happens at. I know this basically is a Salt error reporting issue, but a few checks at the right places to only call .itertitems() on stuff that's actually not empty would be a big help.

johnkeates commented 8 years ago

Sorry, this is a duplicate of #47.