feat(maps): adds tls_policy map for smtp delivery

fzipi commented 4 years ago

Signed-off-by: Felipe Zipitria fzipitria@perceptyx.com

This PR adds smtp_tls_policy_maps. See postfix TLS readme

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[x] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan

feat(maps): adds tls_policy map for smtp delivery

Powered by Pull Assistant. Last update d87da4a ... d87da4a. Read the comment docs.

fzipi commented 4 years ago

I don't think testing with centos6 and salt 2017 would make any good nowadays...

myii commented 4 years ago

I don't think testing with centos6 and salt 2017 would make any good nowadays...

@fzipi Yes, don't worry about that, we're in the process of removing these but we're waiting for the latest release (tomorrow) before upgrading Travis (again).

In the meantime, we need one of the Postfix contributors to have a look at this PR. Let's see if @alxwr or @ixs wouldn't mind having a look.

fzipi commented 4 years ago

Hi @alxwr @ixs, can you review this PR?

myii commented 4 years ago

@daks Since there's no response from the others, any chance of a general review here?

@fzipi If there's no activity in a couple of days, please ping me directly and I'll try to write some tests for this, so at least we're confirming the implementation that way. Or if you'd like to have a go, please make sure to add any pillar values to test/salt/pillar/default.sls so that your states run in Kitchen. These are the only states of config.sls that are running at the moment:

https://travis-ci.com/github/saltstack-formulas/postfix-formula/jobs/332665072#L896-L940

myii commented 4 years ago

Appreciate you making time to review this, @daks.

@fzipi So all this needs before it can be merged is to add tls_policy to the pillar.example, as @daks has mentioned above.

fzipi commented 4 years ago

@myii Done!

@daks I get what you are saying. I have some inspec tests, maybe would push them in a new PR if interested.

Also, now that I see this again. maybe all maps should be below mapping key, and treat them equally. Will try that and if is seems reasonable maybe create a new PR.

Thanks!

Felipe.

myii commented 4 years ago

Merged, thanks to you both @fzipi and @daks.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.19.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / postfix-formula